[Python-checkins] r83531 - in python/branches/py3k: Lib/pstats.py Lib/test/test_pstats.py Misc/NEWS

[georg.brandl]

Author: georg.brandl
Date: Mon Aug  2 19:24:49 2010
New Revision: 83531

Log:
#7372: fix regression in pstats: a previous fix to handle cProfile data in add_callers broke handling of profile data.

Modified:
   python/branches/py3k/Lib/pstats.py
   python/branches/py3k/Lib/test/test_pstats.py
   python/branches/py3k/Misc/NEWS

Modified: python/branches/py3k/Lib/pstats.py
==============================================================================
--- python/branches/py3k/Lib/pstats.py	(original)
+++ python/branches/py3k/Lib/pstats.py	Mon Aug  2 19:24:49 2010
@@ -506,8 +506,13 @@
         new_callers[func] = caller
     for func, caller in source.items():
         if func in new_callers:
-            new_callers[func] = tuple([i[0] + i[1] for i in
-                                       zip(caller, new_callers[func])])
+            if isinstance(caller, tuple):
+                # format used by cProfile
+                new_callers[func] = tuple([i[0] + i[1] for i in
+                                           zip(caller, new_callers[func])])
+            else:
+                # format used by profile
+                new_callers[func] += caller
         else:
             new_callers[func] = caller
     return new_callers

Modified: python/branches/py3k/Lib/test/test_pstats.py
==============================================================================
--- python/branches/py3k/Lib/test/test_pstats.py	(original)
+++ python/branches/py3k/Lib/test/test_pstats.py	Mon Aug  2 19:24:49 2010
@@ -10,10 +10,16 @@
     def test_combine_results(self):
         """pstats.add_callers should combine the call results of both target
         and source by adding the call time. See issue1269."""
+        # new format: used by the cProfile module
         target = {"a": (1, 2, 3, 4)}
         source = {"a": (1, 2, 3, 4), "b": (5, 6, 7, 8)}
         new_callers = pstats.add_callers(target, source)
         self.assertEqual(new_callers, {'a': (2, 4, 6, 8), 'b': (5, 6, 7, 8)})
+        # old format: used by the profile module
+        target = {"a": 1}
+        source = {"a": 1, "b": 5}
+        new_callers = pstats.add_callers(target, source)
+        self.assertEqual(new_callers, {'a': 2, 'b': 5})
 
 
 def test_main():

Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS	(original)
+++ python/branches/py3k/Misc/NEWS	Mon Aug  2 19:24:49 2010
@@ -29,6 +29,9 @@
 Library
 -------
 
+- Issue #7372: Fix pstats regression when stripping paths from profile
+  data generated with the profile module.
+
 - Issue #9428: Fix running scripts with the profile/cProfile modules from
   the command line.