[Python-checkins] r71684 - python/branches/py3k/Python/dtoa.c
mark.dickinson
python-checkins at python.org
Fri Apr 17 18:06:29 CEST 2009
Author: mark.dickinson
Date: Fri Apr 17 18:06:28 2009
New Revision: 71684
Log:
Add reminder to dtoa.c to check for updates regularly.
Fix a bug in the memory management in dtoa.c.
Modified:
python/branches/py3k/Python/dtoa.c
Modified: python/branches/py3k/Python/dtoa.c
==============================================================================
--- python/branches/py3k/Python/dtoa.c (original)
+++ python/branches/py3k/Python/dtoa.c Fri Apr 17 18:06:28 2009
@@ -21,7 +21,11 @@
* This is dtoa.c by David M. Gay, downloaded from
* http://www.netlib.org/fp/dtoa.c on April 15, 2009 and modified for
* inclusion into the Python core by Mark E. T. Dickinson and Eric V. Smith.
- * The major modifications are as follows:
+ *
+ * Please remember to check http://www.netlib.org/fp regularly (and especially
+ * before any Python release) for bugfixes and updates.
+ *
+ * The major modifications from Gay's original code are as follows:
*
* 0. The original code has been specialized to Python's needs by removing
* many of the #ifdef'd sections. In particular, code to support VAX and
@@ -53,6 +57,10 @@
* 5. The code has been reformatted to better fit with Python's
* C style guide (PEP 7).
*
+ * 6. A bug in the memory allocation has been fixed: to avoid FREEing memory
+ * that hasn't been MALLOC'ed, private_mem should only be used when k <=
+ * Kmax.
+ *
***************************************************************/
/* Please send bug reports for the original dtoa.c code to David M. Gay (dmg
@@ -342,7 +350,7 @@
x = 1 << k;
len = (sizeof(Bigint) + (x-1)*sizeof(ULong) + sizeof(double) - 1)
/sizeof(double);
- if (pmem_next - private_mem + len <= PRIVATE_mem) {
+ if (k <= Kmax && pmem_next - private_mem + len <= PRIVATE_mem) {
rv = (Bigint*)pmem_next;
pmem_next += len;
}
More information about the Python-checkins
mailing list