[Python-checkins] r66863 - python/trunk/Modules/posixmodule.c

[Benjamin Peterson]

On Thu, Oct 9, 2008 at 12:34 PM, Brett Cannon <brett at python.org> wrote:
> On Thu, Oct 9, 2008 at 10:30 AM, Raymond Hettinger <python at rcn.com> wrote:
>>> Merges should be handled by the original committer.
>>
>> Respectfully disagree.  Some people here having been taking responsibility
>> for keeping the branches in-sync and are particularly good at
>> spotting/fixing cross branch differences. I think it's okay to defer to
>> them.
>>
>
> OK, how about "encourage" rather than "should"? Doing merges of a ton
> of patches is rather time-consuming and can lead to bugs making it
> through because the mass merge makes it hard to do a thorough review.
> If someone has the time and inclination to try to do the merge
> themselves it is appreciated.

I agree with Brett here. Don't bother with doc typos or trivial bug
fixes/features, but you've just rewritten the compiler doing the merge
yourself is very helpful. The original authors can best determine how
their commit fits into py3k, and it's the only way to insure it
happens the way you want. :)


-- 
Cheers,
Benjamin Peterson
"There's nothing quite as beautiful as an oboe... except a chicken
stuck in a vacuum cleaner."