[issue46487] `_SSLProtocolTransport` doesn't have the `get_write_buffer_limits` implementation.

Andrew Svetlov report at bugs.python.org
Wed Jan 26 12:03:13 EST 2022


Andrew Svetlov <andrew.svetlov at gmail.com> added the comment:

Technically it should not provide the method according to the current design.
get_write_buffer_limits() is not a part of public transports API, this method is defined by private class _FlowControlMixin only.

WriteTransport requires only get_write_buffer_size() and set_write_buffer_limits() *setter* but not get_write_buffer_limits() getter.

I agree, looks weird.
The best solution maybe is adding get_write_buffer_limits() to WriteTransport definition and documenting the change.

Would you prepare a pull request? I'm happy to review/merge it.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue46487>
_______________________________________


More information about the Python-bugs-list mailing list