[issue19683] test_minidom has many empty tests

karl report at bugs.python.org
Thu Jan 7 00:55:30 EST 2021


karl <karl+pythonbugs at la-grange.net> added the comment:

@zach.ware 
@r.david.murray

I'm going through the source currently. 

I see that the test file is using:

class MinidomTest(unittest.TestCase):
    def confirm(self, test, testname = "Test"):
        self.assertTrue(test, testname)


Is there a specific reason to use this form instead of just directly using self.assertEqual or similar forms for new tests or reorganizing some of the tests. 


I see that it is used for example for giving a testname but

    def testAAA(self):
        dom = parseString("<abc/>")
        el = dom.documentElement
        el.setAttribute("spam", "jam2")
        self.confirm(el.toxml() == '<abc spam="jam2"/>', "testAAA")


testAAA is not specifically helping. :)

----------

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue19683>
_______________________________________


More information about the Python-bugs-list mailing list