[issue40655] Fix 'from x import *' which is bad programming practice from 'Lib/ctypes/test/'.

Serhiy Storchaka report at bugs.python.org
Sun May 17 04:30:05 EDT 2020


Serhiy Storchaka <storchaka+cpython at gmail.com> added the comment:

Pure cosmetic changes to satisfy some aesthetic preferences are not accepted. Every changes has its cost (it consumes the time of core developers to review, has maintenance cost, and disturbs the history of the files) and should be made only if it has a clear benefit.

Using star-import is not forbidden, otherwise such syntax would not be supported. ctypes may be one of modules for which using it is well justified: it contains a lot of names, and most of names have unique prefix ("c_") to avoid conflicts with builtins. Especially in tests.

----------
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue40655>
_______________________________________


More information about the Python-bugs-list mailing list