[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

Andrew Svetlov report at bugs.python.org
Sun Sep 15 13:51:08 EDT 2019


Andrew Svetlov <andrew.svetlov at gmail.com> added the comment:

Raymond, sorry if I was so quick in applying.
The patch is very trivial and obvious.
I am pretty sure that Yuri and Victor approve it.

The PR doesn't fix a mistake, the code is still valid.
But we all changed our mind what is the loop role, should it be explicitly passed everywhere or not, etc.

At the time of the example creation explicit loop was safer, after Python 3.5.3 bugfx release the implicit loop became the idiomatic solution.

We use the implicit loop everywhere, 3.8 raises DeprecationWarning for passing the loop into certain API calls.
The PR just changes the example to follow our own recommendations.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue38178>
_______________________________________


More information about the Python-bugs-list mailing list