[issue35967] Better platform.processor support
Jason R. Coombs
report at bugs.python.org
Sat Apr 13 20:46:10 EDT 2019
Jason R. Coombs <jaraco at jaraco.com> added the comment:
> I don't quite follow: since you are the author of the tool, you can of
course have your uname.py import platform and then apply one of the
above tricks.
I thought I'd tried that, but failed [ref](https://github.com/jaraco/cmdix/issues/1#issuecomment-462207845), which is why I committed [this change](https://github.com/jaraco/cmdix/commit/c53908b4b39771eed9f64fff5bed8af51baae4d0).
The problem is that, if `pkg_resources` is used to implement the entry point for the `uname` console script, or if any other library happens to call platform.*, such as in site.py, before the patch has been allowed to run, the invocation of `uname` itself ends up invoking `uname`, causing unlimited recursion. No amount of patching in the `uname` command implementation can help that.
> Your PR is missing tests, though, to support that it actually
returns the same values are before for a set of common platforms.
Yes, that sounds like a good plan. I'll add some tests that assert the values and then update the tests to match the current output, establish a baseline.
----------
_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue35967>
_______________________________________
More information about the Python-bugs-list
mailing list