[issue18407] Fix compiler warnings in pythoncore for Win64

STINNER Victor report at bugs.python.org
Thu Nov 22 08:51:56 EST 2018


STINNER Victor <vstinner at redhat.com> added the comment:

Almost all compiler warnings on 64-bit Windows have been fixed: bpo-9566 tracked most of them.

I extract the CryptGenRandom() fix from issue18407-2.diff. I rewrote the ast.c fix differently (use larger type, don't downcast).

The patch may still contains relevant changes on Python/dtoa.c and Python/getargs.c, but again, the most critical bugs and warnings have already been fixed. So I suggest to abandon issue18407-2.diff which has been written 5 years ago.

Thanks Jeremy Kloth for the report and for the patch! I think that it's now time to close the issue. See bpo-9566 for the few remaining issues.

----------
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue18407>
_______________________________________


More information about the Python-bugs-list mailing list