[issue33274] minidom removeAttributeNode returns None

[Fred L. Drake, Jr.]

Fred L. Drake, Jr. <fdrake at gmail.com> added the comment:

> I saw what looked to me like a bug that's been in the code for 18 years,
> and I saw that it was a simple fix.

And you're right:  It is a bug, the fix is simple, and the risk is low.

Ten years ago, I'd have probably just landed the fix on all applicable branches and moved on.  But the longer something stays the same (like you said, for 18 years now), the more surprising a fix can be when something (however foolishly and unlikely it seems) relied on the old, broken behavior falls apart because of the change.

Please don't think we don't appreciate your contribution; we do.  I hope you'll continue to be observant and catch bugs (even little ones!), and provide fixes.

Feel free to reach out if you'd like to discuss this further.

----------
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue33274>
_______________________________________