[issue34010] tarfile stream read performance regression

[STINNER Victor]

STINNER Victor <vstinner at redhat.com> added the comment:

https://github.com/python/cpython/pull/8020/files/77a54a39aace1a38794884218abe801b85b54e62#diff-ef64d8b610dda67977a63a9837f46349

-            buf = "".join(t)
+            buf = b"".join(t)


@hajoscher: "It never caused a problem, since this line is never called; size is never None in the function call. But still, should be fixed, I guess."

Would it be possible to have an unit test for this modified line? Untested code is broken, as you showed :-)

----------
nosy: +vstinner

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue34010>
_______________________________________