[issue34027] python 3.7 openpty/forkpty build failure using nix package manager macOS environment

[Orivej Desh]

Orivej Desh <orivej at gmx.fr> added the comment:

I understand the desirability of avoiding potential problems on supported platforms (given that you can not test building Python on all of them) and recognize that both options you have given are reasonable, but as I see it posixmodule.c incorrectly uses autoconf checks for the presence of header files to infer the platform: it assumes that libutil.h can not exist on macOS. It should either include all found relevant headers, as proposed in my patch or done e.g. in dropbear [1] and gnulib [2], or it should dispatch on the platform directly as LnL7 has proposed (although in this case it should no longer use the autoconf check on macOS).

[1] https://secure.ucc.asn.au/hg/dropbear/file/DROPBEAR_2018.76/includes.h
[2] http://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/pty.in.h?id=281b825eba78dc403b9bf34979923bc587bc31af

----------

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue34027>
_______________________________________