[issue31324] support._match_test() used by test.bisect is very inefficient

[STINNER Victor]

STINNER Victor <victor.stinner at gmail.com> added the comment:

I merged my PR 4421 which is based on Serhiy's PR 4420. Thank you Serhiy for your reviews!

--

Serhiy Storchaka: "We could split patterns on two parts and create both matchers (...) I don't know whether it is worth to do."

My use bisect is to find a regression using the test.bisect tool. According to my tests, the fastest set().__contains__ matcher is always used, except of test_json. If you bisect a bug in test_json, it will work, but just be a little bit slower.

Honestly, I don't think that we can go further in term of optimization. In my tests, it seems like creating the matcher function and filter all tests take less than 1 second, so it's enough for my use case ;-)

----------
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue31324>
_______________________________________