[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references
STINNER Victor
report at bugs.python.org
Wed Jun 7 05:16:33 EDT 2017
STINNER Victor added the comment:
> At the end, you should get the commit 6b4be195cd8868b76eb6fbe166acc39beee8ce36.
The commit is a giant change. So let me help you, the following change is strange. value is replaced whereas its value is non-NULL... Maybe it's the regression? ;-)
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
index 90f8551..03601ea 100644
--- a/Python/pylifecycle.c
+++ b/Python/pylifecycle.c
@@ -291,6 +291,9 @@ import_init(PyInterpreterState *interp, PyObject *sysmod)
/* Install importlib as the implementation of import */
value = PyObject_CallMethod(importlib, "_install", "OO", sysmod, impmod);
+ if (value != NULL)
+ value = PyObject_CallMethod(importlib,
+ "_install_external_importers", "");
if (value == NULL) {
PyErr_Print();
Py_FatalError("Py_Initialize: importlib install failed");
Stéphane Wirtel (matrixise): "this issue can be executed on Linux, I think I am going to work on this one."
Would you like to work on a patch?
----------
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue30547>
_______________________________________
More information about the Python-bugs-list
mailing list