[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog
Terry J. Reedy
report at bugs.python.org
Sun Jul 30 01:53:57 EDT 2017
Terry J. Reedy added the comment:
Now that we know what we are doing, we can simplify the steps. These assume that #21004, PR2905, which prepares create_widgets and fixes the GeneralTest that was broken by Notebook, has been merged.
For configdialog:
* copy general block after FontPage;
* add 'class GenPage(Frame):' and def __init__ modeled on FontPage.__init__, but no highlight parameter;
* replace 'frame = dialog.tabpages...' at top of create_page_general with 'frame = self';
* comment out old code;
* in create_widgets change 'self.create_page_general' to 'GenPage(note)'.
For test_configdialog:
* change 'GeneralTest' to 'GenPageTest
* change setUpClass similarly as in FontPageTest;
* change test functions similarly as in FontPageTest and otherwise as needed to keep tests passing.
----------
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue31050>
_______________________________________
More information about the Python-bugs-list
mailing list