[issue29301] decimal: Use FASTCALL and/or Argument Clinic
STINNER Victor
report at bugs.python.org
Fri Jan 27 10:52:55 EST 2017
STINNER Victor added the comment:
Stefan Krah:
> AC will not happen: It makes the module too large and unreadable.
Ah you dislike the additional [clinic input] sections?
It's kind of strange when you have to convert existing code, when once
the code uses AC, I prefer AC to separated documentation variables. It
helps to keep docstrings more up to date, and it helps to enhance the
API (ex: allow keywords, rename parameters to better names, etc.). It
also helps to make the documentation closer to the code, which is IMHO
a good thing :-)
IMHO the PyArg_ParseXXX() calls and their "kwlist" static variable are
"unreadable", and I'm happy to be able to hide them!
FYI decimal-2.patch replaces PyArg_ParseTupleAndKeywords() with
_PyArg_ParseStackAndKeywords() with static _PyArg_Parser object. This
object only decides keyword names once and is more efficient to parse
arguments. It explains partially the speedup. Only partially because
bm_telco only calls the .quantize() method, and it only uses
positional arguments (no keyword arguments) ;-)
----------
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue29301>
_______________________________________
More information about the Python-bugs-list
mailing list