[issue29171] Remove unused blake2 function to avoid undefined references

[Eric N. Vander Weele]

New submission from Eric N. Vander Weele:

Compilers are not required to elide static functions which are unused.

Some compilers, such as Solaris Studio, always emits the function, even
if the function does not get called within the translation unit.  This
becomes problematic when a static inline function calls a non-existent
function; thus, resulting in (dynamic or static) link time errors.

Given that 'blake2' is never referenced nor called, remove the
definition of this function to increase portability for non-Linux
toolchains.

https://blogs.oracle.com/d/entry/inline_functions_in_c also indicates that this is case for Solaris Studio as well.

----------
components: Build
files: blake2-remove-unused-function-1.patch
keywords: patch
messages: 284781
nosy: christian.heimes, ericvw
priority: normal
severity: normal
status: open
title: Remove unused blake2 function to avoid undefined references
type: behavior
versions: Python 3.6
Added file: http://bugs.python.org/file46165/blake2-remove-unused-function-1.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue29171>
_______________________________________