[issue29452] Use FASTCALL for collections.deque methods: index, insert, rotate

Raymond Hettinger report at bugs.python.org
Mon Feb 6 02:32:56 EST 2017


Raymond Hettinger added the comment:

Over this looks good.  Just one other minor tweak (one that has served me well elsewhere) would be to bypass the cross-module function call with a cheap (near zero cost) register variable test:

    if (kwnames != NULL && !_PyArg_NoStackKeywords("rotate", kwnames)) {
        return NULL;
    }

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue29452>
_______________________________________


More information about the Python-bugs-list mailing list