[issue28148] [Patch] Also stop using localtime() in timemodule

Alexander Belopolsky report at bugs.python.org
Wed Sep 14 17:29:28 EDT 2016


Alexander Belopolsky added the comment:

> I thought `[...]localtime_r()`'s way of ordering the arguments made most sense here.

Right. I keep forgetting which one is localtime_r and which is localtime_s. I don't think there is any preference in the Python codebase. (PEP 8 is silent on this point.)

Use of time_t instead of time_t* makes it obvious which argument is input, so as I said, for me the order does not matter.  Google style guide is reason enough to pick the order.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue28148>
_______________________________________


More information about the Python-bugs-list mailing list