[issue28123] _PyDict_GetItem_KnownHash ignores DKIX_ERROR return

STINNER Victor report at bugs.python.org
Tue Sep 13 06:57:00 EDT 2016


STINNER Victor added the comment:

Xiang Zhang added the comment:
> How about let PyDict_GetItem call it?

PyDict_GetItem() is like the most important function in term of
performance for Python. If you want to touch it, you must benchmark
it.

I would prefer to keep it as it is.

> Just like the relationship of delitem and delitem_knownhash.

delitem is less important in term of performance, so I decided to
accept Naoki's change to merge duplicated code.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue28123>
_______________________________________


More information about the Python-bugs-list mailing list