[issue23102] distutils: isinstance checks fail with setuptools-monkeypatched Extension/Distribution

[Berker Peksag]

Berker Peksag added the comment:

The patch doesn't apply cleanly:

applying http://bugs.python.org/file37554/distutils_accomodate_distribution_ducktypes.patch
patching file Lib/distutils/cmd.py
Hunk #1 FAILED at 51
1 out of 1 hunks FAILED -- saving rejects to file Lib/distutils/cmd.py.rej
abort: patch failed to apply

So the next step would be to update the patch.

We also need a test case to make sure that the patch fixes the problem reported in msg233034.

+1 for relying on duck typing. Perhaps we could also look for methods that are called in Command (e.g. get_command_obj(), run_command())

----------
nosy: +berker.peksag, jason.coombs
stage:  -> needs patch
versions: +Python 3.7 -Python 3.4

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue23102>
_______________________________________