[issue28544] Implement asyncio.Task in C
Yury Selivanov
report at bugs.python.org
Fri Oct 28 13:00:43 EDT 2016
Yury Selivanov added the comment:
I've committed the patch with a few touchups:
* Applied code-review feedback.
* We now use AC for all methods, including Task._repr_info, Task._step, etc. See [1].
* I fixed the Task to be fully subclassable; users can override Task._step and Task._wakeup now. There are tests for ensuring that subclassing works the same for both Python and C implementations. See [2] and [3].
* I made it possible to override Future._schedule_subclass, as it was in Python 3.5. See [4].
Andrew, Inada-san, thank you for reviewing the patch! Please take a look at the patch updates referenced below. Feel free to re-open the issue if you see anything suspicious.
[1] https://github.com/1st1/cpython/commit/99adc35c94d76d78b8e666381436016c3c74a5ab
[2] https://github.com/1st1/cpython/commit/e294491c4cc7c92bc94ff12b4796c8ab12c40435
[3] https://github.com/1st1/cpython/commit/4d1c50c8987af124ce0bcccaea6bde82a60b59ee
[4] https://github.com/1st1/cpython/commit/efec03cbb4f81e78defd989d72c9bdae1122f50d
----------
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue28544>
_______________________________________
More information about the Python-bugs-list
mailing list