[issue21449] Replace _PyUnicode_CompareWithId with _PyUnicode_CompareWithIdEqual

Serhiy Storchaka report at bugs.python.org
Tue Nov 15 13:08:30 EST 2016


Serhiy Storchaka added the comment:

> Callers should be fixed to handle errors.

This would make the code of callers more complex for small benefit. And perhaps we will add more callers (if replace PyUnicode_CompareWithASCII with new function).

> Since currently _PyUnicode_CompareWithId is used to compare a unicode with ascii identifiers for all cases, how about introduce a more specific function like _PyUnicode_EqualToASCIIId for this case?

Great idea Xiang!

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue21449>
_______________________________________


More information about the Python-bugs-list mailing list