[issue28685] Optimizing list.sort() by performing safety checks in advance

Julien Palard report at bugs.python.org
Mon Nov 14 08:09:50 EST 2016


Julien Palard added the comment:

Hi Elliot, nice spot!

Why are you redefining Py_ABS, which looks already defined in `pymacro.h` included itself by `Python.h`? I'm not fan of undefining it later, it may surprise someone later expecting it to be there.

I tried to compile without your definition of Py_ABS, just in case I missed something in the includes, and it works.

----------
nosy: +mdk

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue28685>
_______________________________________


More information about the Python-bugs-list mailing list