[issue23951] Update devguide style to use a similar theme as Docs

STINNER Victor report at bugs.python.org
Wed Jul 20 18:40:24 EDT 2016


STINNER Victor added the comment:

Berker Peksag
> -1. I think the current devguide theme looks fine and it would be nice to keep devguide and Python documentations use different themes.

I pushed the change because there were 3 positive votes and no negative vote, and I like the proposed them.


> I'd be -0 if the patch was small, but diff stat "11 files changed, 1651 insertions(+), 10 deletions(-)" is huge and it would be nice to avoid  code duplication. The current theme has some bugs and now we will have to update two different repos everytime we touch the docs.p.o theme.

Sorry but I don't know anything about Sphinx theme. If you know how to fix mentionned issues, please write a patch and/or push directly changes.


> It seems like devguide_theme_revised.patch was committed accidentally: https://hg.python.org/devguide/rev/9e7b1bc15ba7#l3.3

What do you mean? It was deliberate for me to push devguide_theme_revised.patch. I don't see strong reason in comments to not push the change.


> I'd also delete rstllint.py.

It adds a new "make check" which doesn't hurt.

Maybe it may be better to contribute to Sphinx, but again, it's short and doesn't hurt.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue23951>
_______________________________________


More information about the Python-bugs-list mailing list