[issue28838] Using consistent naming for arguments of "call" functions (C API)
Serhiy Storchaka
report at bugs.python.org
Tue Dec 6 14:37:13 EST 2016
Serhiy Storchaka added the comment:
> It don't think that my change makes abstract.h worse, some comments were far
> from their declaration, and there is was no unique style for comments. It's
> a mess.
Seems most of comments that did not follow common style are your comments to
"fast call" functions. It would be better to fix only that comments.
> "That would be very large patch, and I doubt it will be approved."
> Why not?
Because it breaks "hg annotation" and makes harder researching the history of
the file. That harms the workflow of other developers. Ask on Python-Dev before
making such larger and questionable changes.
> You reviewed rename.patch, I only made tiny changes after this patch.
Reviewed patch did not contain committed changes. That changes are not tiny.
----------
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue28838>
_______________________________________
More information about the Python-bugs-list
mailing list