[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[STINNER Victor]

STINNER Victor added the comment:

"""

If shifting right twice (adding parens for clarity):

    (LONG_MAX >> PyLong_SHIFT) >> PyLong_SHIFT.

squashes the warnings, that would be a substantially clearer way to express the intent than the

    SIZEOF_LONG*CHAR_BIT-1 >= 2*PyLong_SHIFT

spelling.  Adding a comment *explaining* the intent would be even better.
"""

Ok, here is a patch implementing this issue: long_shift_ub.patch.

I'm unable to test it with ICC, but we can try to push it and check on the ICC buildbots.

----------
keywords: +patch
Added file: http://bugs.python.org/file40503/long_shift_ub.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue24999>
_______________________________________