[issue18643] add a fallback socketpair() implementation in test.support
Charles-François Natali
report at bugs.python.org
Thu Jul 24 10:11:52 CEST 2014
Charles-François Natali added the comment:
> By the way, we should reuse socket.socketpair() in
> asyncio.windows_utils. The Tulip is written for Python 3.3 and shares
> exactly the same code base, so you should write
>
> Something like:
>
> if hasattr(socket, 'socketpair'):
> socketpair = socket.socketpair
> else:
> def socketpair(...): ...
>
> Please also fix socketpair() in asyncio to add the while/drop unknown
> connection (well, the function in socket.py and windows_utils.py must
> be the same).
That's a separate issue.
> Oh, and you forgot to modify the documentation to update
> "Availability". Please add a ".. versionchanged:: 3.5" mentionning
> that the function is now also available on Windows.
Did you look at the patch?
363 .. versionchanged:: 3.5
364 Windows support added
----------
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue18643>
_______________________________________
More information about the Python-bugs-list
mailing list