[issue20189] inspect.Signature doesn't recognize all builtin types

Larry Hastings report at bugs.python.org
Wed Jan 15 00:23:44 CET 2014


Larry Hastings added the comment:

Updated the patch.  (Diff #2 apparently didn't apply cleanly, so we didn't get a review link.)


Old-guard core devs: I'm *really* desperate for a review of this patch.  You don't have to review everything thing, just these files:

    * Include/object.h
    * Objects/descrobject.c
    * Objects/methodobject.c
    * Objects/typeobject.c

I can get a different reviewer for the other files.  But I worry about touching these tender bits of the type system and I want to make sure that

a) I haven't done something awful, and
b) I haven't missed something important.

Just that part of the diff is 345 lines, and it's pretty regular.  I'd be surprised if it took you a whole hour.

If you have any questions email me, I'd be thrilled to answer 'em if it means I can get this patch checked in.  Maintaining the patch is overhead that I just don't need during the Derby.

----------
nosy: +barry
Added file: http://bugs.python.org/file33469/larry.support.text_signature.on.more.types.diff.3.txt

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue20189>
_______________________________________


More information about the Python-bugs-list mailing list