[issue21259] replace "except: pass" by "except Exception: pass"

[Raymond Hettinger]

Raymond Hettinger added the comment:

> Please don't close the issue, Stéphane is fixing real bug.

He appears to be doing a blanket search and replace without adding tests, without evaluating each change to see if makes sense, and without consulting the original author of each affected piece of code.

We have never received a bug report on any one of these.  If you think any one of them is an actually bug, it should be carefully considered one at a time, evaluating why the bare except was put there in the first place.  

Guido pushes for holistic refactoring for a reason.  It is too easy to introduce bugs into stable code by these kind of wholesale changes.

If you (Victor) want to individually study each one to make sure it is the right thing to do, I would place more faith in the patch.  But as it stands now, reviewing the patch for correctness will take substantially more care and thought than it took to create it in the first place.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue21259>
_______________________________________