[issue19106] Prepare .hgtouch and Tools/hg/hgtouch.py to run on the bots

Eli Bendersky report at bugs.python.org
Fri Sep 27 19:00:26 CEST 2013


Eli Bendersky added the comment:

The problem in this case is different, actually. It's the comparison:

        if o_time <= i_time:
            # generated file is older, touch
            need_touch = True

In check_rule. The script is pretty quick so when it touches both Python-ast.h and .c they get the same stat time exactly. In the next run, then, this comparison succeeds and .c is touched again.

I'm not sure what's the right way to go about this? Changing the comparison to < may theoretically miss cases in which the input was updated an epsilon after it auto-generated its output, and the change will go unnoticed. A different solution would be to introduce a micro-wait between each 'touch' to make sure that transitive dependencies don't need to be revisited in the future.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue19106>
_______________________________________


More information about the Python-bugs-list mailing list