[issue19692] Rename Py_SAFE_DOWNCAST

Antoine Pitrou report at bugs.python.org
Fri Nov 22 16:45:04 CET 2013


Antoine Pitrou added the comment:

> -1. The macro name doesn't claim the cast to be safe, i.e. it's not
> "Py_SAFELY_DOWNCAST", but "safe downcast", i.e. it's an assertion that
> the cast actually has been verified as being safe.

It's not an assertion, it's a cast.
Otherwise it should be named Py_ASSERT_SAFE_DOWNCAST (and it should only
do the assertion, not the cast).

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue19692>
_______________________________________


More information about the Python-bugs-list mailing list