[issue16611] multiple problems with Cookie.py

[John Dennis]

John Dennis added the comment:

I think your basic approach is fine and it's O.K. to break backwards compatibility. I'm not sure anyone was using the httponly and secure flags in the past because it was so broken, the logic was completely contradictory, so backwards compatibility should not trump fixing obviously broken logic.

I didn't review your patch carefully, just a really quick glance. The one thing that did pop out was compiling the static regexp every time the function is called. Why not make it a module or class object and compile once at load time?

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue16611>
_______________________________________