[issue18480] _elementtree: missing PyType_Ready call

[Christian Heimes]

Christian Heimes added the comment:

Good catch!

ElementIter_Type has no prototype, too.

$ grep Type Modules/_elementtree.c  | grep static
static PyTypeObject Element_Type;
static PyTypeObject Element_Type = {
static PyTypeObject ElementIter_Type = {
static PyTypeObject TreeBuilder_Type;
static PyTypeObject TreeBuilder_Type = {
static PyTypeObject XMLParser_Type;
static PyTypeObject XMLParser_Type = {

How about you move the prototypes for all four types to the head of the file? For example the ssl.c module declares all types up front. It makes it more clear which types are defined by the module.

----------
nosy: +christian.heimes

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue18480>
_______________________________________