[issue15650] PEP 3121, 384 refactoring applied to dbm module

[Andrew Svetlov]

Andrew Svetlov added the comment:

Robin, after thinking I would to agree with your decision to hold reference to type into type instance.

Please, can you describe your check like:

if((void *)type->tp_dealloc == (void *)dbm_dealloc) {
    Py_DECREF(type);
}

Why you decref only if type->tp_dealloc points to module's dealloc? What are you protected from? What other values also possible?

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue15650>
_______________________________________