[issue5758] fileinput.hook_compressed returning bytes from gz file

[Éric Araujo]

Éric Araujo <merwok at netwok.org> added the comment:

> For 3.2 could we use the same fix, but without exposing the ability to *change* the encoding?
> That is, we use TextIOWrapper but always with the default None for encoding.
Yes!

> It also occurs to me that this really exposes a weakness in the design.  What if the user wants to
> specify other open parameters?  I wonder if we should say that for better future-proofing openhooks
> should always take **kw.  You could even envision fileinput accepting **kw and passing them along
> to the openhook.  I think charset is the most important open paramenter in this context, though, so
> I don't think we have to solve the general problem in this fix.
I concur.  I’ve never had to care about buffering for example, but mode is another parameter of open that people may want to give.  I’ll commit the minimal fix to 3.2 and merge in 3.3, and then we can discuss on a new RFE bug about adding encoding vs. **kwargs for 3.3.

Agreed on deprecating the charset hook when it becomes redundant.

Will fix the doc bug about codecs.open too.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue5758>
_______________________________________