[issue12837] Patch for issue #12810 removed a valid check on socket ancillary data

[Brett Cannon]

Brett Cannon <brett at python.org> added the comment:

Since we never solved this I'm still getting compiler warnings. Can we decide on a solution for this so I can go back to be warning-free (sans `-Wno-unused-value -Wno-empty-body -Qunused-arguments`)?


/Users/bcannon/Developer/repo/cpython/bootstrap_importlib/Modules/socketmodule.c:1439:22: warning: comparison of unsigned expression < 0 is always false
      [-Wtautological-compare]
        if (flowinfo < 0 || flowinfo > 0xfffff) {
            ~~~~~~~~ ^ ~
/Users/bcannon/Developer/repo/cpython/bootstrap_importlib/Modules/socketmodule.c:1948:74: warning: comparison of unsigned expression < 0 is always false
      [-Wtautological-compare]
    if (cmsgh == NULL || msg->msg_control == NULL || msg->msg_controllen < 0)
                                                     ~~~~~~~~~~~~~~~~~~~ ^ ~
/Users/bcannon/Developer/repo/cpython/bootstrap_importlib/Modules/socketmodule.c:5062:18: warning: comparison of unsigned expression < 0 is always false
      [-Wtautological-compare]
    if (flowinfo < 0 || flowinfo > 0xfffff) {
        ~~~~~~~~ ^ ~
3 warnings generated.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue12837>
_______________________________________