[issue15463] test_faulthandler can fail if install path is too long

Chris Jerdonek report at bugs.python.org
Wed Aug 1 20:35:56 CEST 2012


Chris Jerdonek added the comment:

> Yes, I saw your patch, but I don't want to create very long filename.
Not all platforms support paths longer than 500 characters.

I think you may have a slight misunderstanding.  My patch was not meant to test paths over 500 characters.  It tests a path *under* 500 characters (but slightly over 100 characters).  And it has the same style and portability characteristics as the existing ".*threading.py" tests.

> My patch is different than yours: it checks that the string is
truncated, not that string shorter than the limit are not truncated.

Yes, your patch is different in two ways. :) It tests function names instead of paths, and length > 500 instead of 100 < length < 500.  I think there is value in adding a file path test because code changes over time, so it may not always be using the same code path as function names.

I agree that it is okay to leave out a file path test for longer than 500 characters for the portability reasons you stated.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue15463>
_______________________________________


More information about the Python-bugs-list mailing list