[issue8591] update mkpkg to latest coding standards

Éric Araujo report at bugs.python.org
Mon Sep 19 16:23:07 CEST 2011


Éric Araujo <merwok at netwok.org> added the comment:

> Changing “if s in 'yn'” to “if s in ('y', 'n')” is not really an
> improvement. It’s not more readable to always use tuples or frozensets
> for membership testing; str has __contains__ for a reason :)

Let me eat my words: using “in 'yn'” matches '' and 'yn', which we don’t want.  Changed in 10fd0d0895a1.

----------
versions: +Python 3.3

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue8591>
_______________________________________


More information about the Python-bugs-list mailing list