[issue10924] Adding salt and Modular Crypt Format to crypt library.
Ezio Melotti
report at bugs.python.org
Tue Feb 22 13:24:36 CET 2011
Ezio Melotti <ezio.melotti at gmail.com> added the comment:
Some buildbots are failing after the commit.
Also in the crypt.py module I still see things that according to msg126453 should be fixed already:
* more statements on the same line (e.g. "if salt == None: salt = mksalt()");
* the hardcoded salt values instead of string.ascii_letters;
According to the PEP8 there shouldn't be any spaces after the '[' and before the ']' (e.g. "method_list = [ METHOD_SHA512, METHOD_SHA256, METHOD_MD5 ]" and in the listcomps) and around the = in the function/method declarations/calls (e.g. "def crypt(word, salt = None):").
----------
keywords: +buildbot
nosy: +ezio.melotti
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue10924>
_______________________________________
More information about the Python-bugs-list
mailing list