[issue11707] Create C version of functools.cmp_to_key()

Eric Smith report at bugs.python.org
Sat Apr 2 22:47:22 CEST 2011


Eric Smith <eric at trueblade.com> added the comment:

I haven't had time to look at this in detail, but the concept appears sound. I'll try to devote some time to it, but hopefully someone else on core-mentorship with more familiarity with this code will also be able to review it.

One thing: You don't want to delete the pure Python version, as that can be used by alternate implementations. You want to leave it in place, and then after it try to import the C version. If the import fails, the Python version will be used, if it succeeds, the C version will be used. I'm reasonably sure there are examples of testing both implementations elsewhere in the stdlib. Maybe ask on core-mentorship for pointers.

Thanks for working on this!

----------
nosy: +eric.smith

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue11707>
_______________________________________


More information about the Python-bugs-list mailing list