[issue9075] ssl module sets "debug" flag on SSL struct

[Antoine Pitrou]

New submission from Antoine Pitrou <pitrou at free.fr>:

The ssl module sets a "debug" flag on the OpenSSL SSL struct at the end of PySSL_SSLdo_handshake():

    self->ssl->debug = 1;

The OpenSSL header files have this to say about this flag:

        /* set this flag to 1 and a sleep(1) is put into all SSL_read()
         * and SSL_write() calls, good for nbio debuging :-) */
        int debug;      

Some uses of it in the OpenSSL source are actually guarded by a macro (#ifdef PKT_DEBUG), but some are not. Bill, do you remember why you put that call? I would find it strongly preferrable to remove that assignment (doing so doesn't seem to break anything in the test suite).

----------
components: Library (Lib)
messages: 108561
nosy: exarkun, giampaolo.rodola, janssen, pitrou
priority: high
severity: normal
status: open
title: ssl module sets "debug" flag on SSL struct
type: behavior
versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9075>
_______________________________________