[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

[Meador Inge]

Meador Inge <meadori at gmail.com> added the comment:

> That bit is not in the trunk, should it be forward ported to the trunk?

FWIW, I would really like to have it.

> The actual prototype on 10.5 and 10.6 is:
>
> char           **completion_matches(const char *, CPFunction *);
>
> Wouldn't it be better to change the prototype in readline.c to match?

I may have missed something, but the patch is actually *excluding* the
prototype on OS X, i.e. #if *not* defined.  Thus the 'const char*' prototype
that comes in with 'readline.h' is the one that will be used.

On the other hand, if you are proposing to make them 'match' just to avoid
the redefinition conflict, then this may break on other systems where 'char
*' is used.

Regards,

-- Meador

----------
Added file: http://bugs.python.org/file16169/unnamed

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue6877>
_______________________________________
-------------- next part --------------
<div><div>&gt;Â That bit is not in the trunk, should it be forward ported to the trunk?</div><div><br></div><div>FWIW, I would really like to have it.</div><div><br></div><div>&gt; The actual prototype on 10.5 and 10.6 is:<br>
&gt;<br>&gt; char           **completion_matches(const char *, CPFunction *);<br>&gt;<br>&gt; Wouldn&#39;t it be better to change the prototype in readline.c to match?</div><div><br></div><div>I may have missed something, but the patch is actually *excluding* the prototype on OS X, i.e. #if *not* defined.  Thus the &#39;const char*&#39; prototype that comes in with &#39;readline.h&#39; is the one that will be used.</div>
<div><br></div><div>On the other hand, if you are proposing to make them &#39;match&#39; just to avoid the redefinition conflict, then this may break on other systems where &#39;char *&#39; is used.</div><div><br></div><div>
Regards,</div><div><br><div class="gmail_quote">-- Meador</div>
</div></div>