[issue3890] ssl.SSLSocket.recv() implementation may not work with non-blocking sockets

[Bill Janssen]

Bill Janssen <bill.janssen at gmail.com> added the comment:

On Tue, Sep 29, 2009 at 12:47 PM, Giampaolo Rodola'
<report at bugs.python.org>wrote:

>
> Giampaolo Rodola' <billiejoex at users.sourceforge.net> added the comment:
>
> Uhm... I'm sorry but actually I'm not sure about this patch anymore.
> Now that I look at ssl.py again I'm noticing that send() is trapped in a
> "while True" loop as well and the patch doesn't cover it.
>
> Not sure if that has been added recently or it was already there at the
> time I submitted the report but it's another thing that need to be
> fixed.
>
>
> Moreover, I'm sure that removing the "while" loop is good for non-
> blocking sockets but what about blocking ones?
> Are SSL_ERROR_WANT_READ and SSL_ERROR_WANT_WRITE supposed to be raised
> in a blocking environment?
>

No.

> If they aren't then the current patch just needs to take care of send()
> method too, then it's fine.
>

Yes, it's fine.

Bill

----------
Added file: http://bugs.python.org/file15010/unnamed

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue3890>
_______________________________________
-------------- next part --------------
<br><br><div class="gmail_quote">On Tue, Sep 29, 2009 at 12:47 PM, Giampaolo Rodola&#39; <span dir="ltr">&lt;<a href="mailto:report at bugs.python.org">report at bugs.python.org</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Giampaolo Rodola&#39; &lt;<a href="mailto:billiejoex at users.sourceforge.net">billiejoex at users.sourceforge.net</a>&gt; added the comment:<br>
<br>
Uhm... I&#39;m sorry but actually I&#39;m not sure about this patch anymore.<br>
Now that I look at ssl.py again I&#39;m noticing that send() is trapped in a<br>
&quot;while True&quot; loop as well and the patch doesn&#39;t cover it.<br>
<br>
Not sure if that has been added recently or it was already there at the<br>
time I submitted the report but it&#39;s another thing that need to be<br>
fixed.<br>
<br>
<br>
Moreover, I&#39;m sure that removing the &quot;while&quot; loop is good for non-<br>
blocking sockets but what about blocking ones?<br>
Are SSL_ERROR_WANT_READ and SSL_ERROR_WANT_WRITE supposed to be raised<br>
in a blocking environment?<br></blockquote><div><br>No.<br>Â <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
If they aren&#39;t then the current patch just needs to take care of send()<br>
method too, then it&#39;s fine.<br></blockquote><div><br>Yes, it&#39;s fine.<br><br>Bill <br></div></div><br>