[issue1424152] urllib/urllib2: HTTPS over (Squid) Proxy fails

[Christopher Li]

Christopher Li <python at chrisli.org> added the comment:

Hi NL,

Can you please try this patch on top of the original patch?

Thanks

Chris

--- .pc/fix-up/urllib2.py       2008-02-06 01:13:10.000000000 -0800
+++ urllib2.py  2008-06-27 15:45:34.000000000 -0700
@@ -253,7 +253,7 @@ class Request:
         return self.__r_host

     def set_proxy(self, host, type):
-        if self.type == 'https' and not self._tunnel_host:
+        if self.get_type() == 'https' and not self._tunnel_host:
             self._tunnel_host = self.host
         else:
             self.type = type

On Fri, Jun 27, 2008 at 3:22 PM, nfl <report at bugs.python.org> wrote:
>
> nfl <nflpython at irto.hu> added the comment:
>
> Hi,
>
> looks like the attached patch only works if I use
> urllib2.ProxyHandler({'https' : proxy}) at the start, but not when I use
> request.set_proxy(proxy, 'https') per request. I tested with Python
> 2.5.1 on Win32.
>
> ----------
> nosy: +nfl
>
> _______________________________________
> Python tracker <report at bugs.python.org>
> <http://bugs.python.org/issue1424152>
> _______________________________________
>

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue1424152>
_______________________________________