[issue3160] Building a Win32 binary installer crashes

[Antoine Pitrou]

Antoine Pitrou <pitrou at free.fr> added the comment:

Hi Viktor,

It's complicated for me to test under Windows right now, but your
snippet looks buggy:

            script_data = open(self.pre_install_script, "r").read()
            cfgdata = cfgdata + script_data + b"\n\0"

script_data is an unicode string because the file is opened in text
mode, but you try to concatenate it with bytes objects which will fail.
Please try to fix this and provide a proper patch :-)

PS : I agree it is important to fix this.

----------
keywords: +patch
nosy: +pitrou
priority:  -> high

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue3160>
_______________________________________