[ python-Bugs-1679498 ] Lib/io.py open uses unset "bs"

[SourceForge.net]

Bugs item #1679498, was opened at 2007-03-12 22:28
Message generated for change (Settings changed) made by gvanrossum
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1679498&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Python Library
Group: Python 3000
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Jim Jewett (jimjjewett)
Assigned to: Guido van Rossum (gvanrossum)
Summary: Lib/io.py open uses unset "bs"

Initial Comment:

Within the open function, it says
"""
        try:
            bs = os.fstat(raw.fileno()).st_blksize
        except (os.error, AttributeError):
            if bs > 1:
                buffering = bs
"""

Since this is the first use of name "bs", I wouldn't expect it to have any value after an Exception.  If this is actually correct, it at least deserves a comment.

-----------------

(second issue)

_PyFileIO sets self._writable but doesn't use it (even in writable())

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2007-03-17 23:42

Message:
Logged In: YES 
user_id=6380
Originator: NO

Thanks for reporting this!

First issue: Committed revision 54424.

Second issue: Committed revision 54425.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1679498&group_id=5470