[ python-Bugs-1740572 ] asynchat should call "handle_close"

[SourceForge.net]

Bugs item #1740572, was opened at 2007-06-20 13:19
Message generated for change (Comment added) made by josiahcarlson
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1740572&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: billiejoex (billiejoex)
Assigned to: Josiah Carlson (josiahcarlson)
Summary: asynchat should call "handle_close"

Initial Comment:
When 'close_when_done' is used and the producer is consumed 'close' method is called.
IMO a better delegation design would be calling handle_close instead, just like recv already does.

----------------------------------------------------------------------

>Comment By: Josiah Carlson (josiahcarlson)
Date: 2007-06-23 07:07

Message:
Logged In: YES 
user_id=341410
Originator: NO

Indeed, asynchat.async_chat.refill_buffer() should call handle_close()
rather than close().

In the patch I recently provided, it calls handle_close() in the
equivalent method.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1740572&group_id=5470