[ python-Bugs-1298709 ] _socket module not build under cygwin

[SourceForge.net]

Bugs item #1298709, was opened at 2005-09-22 05:59
Message generated for change (Comment added) made by nnorwitz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1298709&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Python 2.4
Status: Open
Resolution: None
Priority: 5
Submitted By: Miki Tebeka (tebeka)
Assigned to: Jason Tishler (jlt63)
Summary: _socket module not build under cygwin

Initial Comment:
Hello,

Bulding Python-2.4.2c1 under cygwin gives the following:

building '_socket' extension
gcc -DNDEBUG -g -O3 -Wall -Wstrict-prototypes
-fno-strict-aliasing -I.
-I/home/mtebeka/src/Python-2.4.2c1/./Include
-I/home/mtebeka/src/Python-2.4.2c1/Include
-I/home/mtebeka/src/Python-2.4.2c1 -c
/home/mtebeka/src/Python-2.4.2c1/Modules/socketmodule.c
-o build/temp.cygwin-1.5.18-i686-2.4/socketmodule.o
/home/mtebeka/src/Python-2.4.2c1/Modules/socketmodule.c:
In function `socket_inet_ntop':
/home/mtebeka/src/Python-2.4.2c1/Modules/socketmodule.c:3351:
error: `INET_ADDRSTRLEN' undeclared (first use in this
function)
/home/mtebeka/src/Python-2.4.2c1/Modules/socketmodule.c:3351:
error: (Each undeclared identifier is reported only once
/home/mtebeka/src/Python-2.4.2c1/Modules/socketmodule.c:3351:
error: for each function it appears in.)
/home/mtebeka/src/Python-2.4.2c1/Modules/socketmodule.c:3351:
warning: unused variable `ip'


----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2005-09-22 21:56

Message:
Logged In: YES 
user_id=33168

Patch is also #1275079.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2005-09-22 21:31

Message:
Logged In: YES 
user_id=33168

Jason, are you still working on Cygwin issues?

----------------------------------------------------------------------

Comment By: Miki Tebeka (tebeka)
Date: 2005-09-22 06:22

Message:
Logged In: YES 
user_id=358087

The problem can be sloved by adding the following lines in
socketmodule.c beginning.

/* FIXME: We should include ws2tcpip.h, however this causes
compilation problems */
#if defined(__CYGWIN__)
#define INET_ADDRSTRLEN  16
#define INET6_ADDRSTRLEN 46
#endif /* __CYGWIN__ */

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1298709&group_id=5470