[Python-bugs-list] [ python-Bugs-822668 ] tarfile exception on large .tar files

[SourceForge.net]

Bugs item #822668, was opened at 2003-10-13 07:20
Message generated for change (Settings changed) made by akuchling
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=822668&group_id=5470

Category: Python Library
Group: Python 2.3
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Johan Fredrik Öhman (johanfo)
Assigned to: A.M. Kuchling (akuchling)
Summary: tarfile exception on large .tar files

Initial Comment:
The following exception is thrown when I write a lot of 
data > 10Gb directly to my tapestreamer.  Is this 
normal? 

Traceback (most recent call last):
  File "/usr/local/metroField/fieldPlugins/Backup.py", line 
184, in run
    self._doBackup()
  File "/usr/local/metroField/fieldPlugins/Backup.py", line 
333, in _doBackup
    arc.close()
  File "/usr/local/metroField/fieldPlugins/Backup.py", line 
533, in close
    self.tf.close()
  File "/usr/local/lib/python2.3/tarfile.py", line 1009, in 
close
    self.fileobj.close()
  File "/usr/local/lib/python2.3/tarfile.py", line 360, in 
close
    self.fileobj.write(struct.pack("<L", self.pos))
OverflowError: long int too large to convert

----------------------------------------------------------------------

>Comment By: A.M. Kuchling (akuchling)
Date: 2003-10-24 13:39

Message:
Logged In: YES 
user_id=11375

Thanks for reporting this bug; your suggested change seems to be correct.
Applied to CVS as rev. 1.9 of tarfile.py

The Jython bug should be reported to whatever bug tracker the Jython 
developers use; they won't see the bug if it's in this bug tracker.  Try looking at 
www.jython.org.

----------------------------------------------------------------------

Comment By: Johan M. Hahn (johahn)
Date: 2003-10-15 16:17

Message:
Logged In: YES 
user_id=887415

Hi, I think I've found the correct solution to the problem 
(though I havn't actually tested it). Looking in tarfile.py...




358:   if self.type == "gz":


359:       self.fileobj.write(struct.pack("<l", self.crc))


360:       self.fileobj.write(struct.pack("<L", self.pos))




...shows that this error only occurs when using .gz extensions. 
Testing shows that this error occurs when self.pos > sys.
maxint*2+2, that is for files larger than 4Gb. This is not good 
since the newest tar and gzip versions can handle files larger 
than that.


   According to the gzip file format spec from www.wotsit.org, 
the last 4 bytes of a gzip file "contains the size of the original 
(uncompressed) input data modulo 2^32". All that has to be 
done is to perform this calculation prior to the call to struct.
pack. Here is my proposed fix:




358:   if self.type == "gz":


359:       self.fileobj.write(struct.pack("<l", self.crc))


360:       self.fileobj.write(struct.pack("<L", self.pos % 2**32)
)




   I also noted that in Jython 2.1 struct.pack('<L', sys.
maxint*2+2) does not raise an OverflowError but wraps around 
and returns '\x00\x00\x00\x00'. This results in the correct size 
calculation for gzip but to silent the overflow is probably not a 
good idea.




...johahn


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=822668&group_id=5470